search

mt-mods / pipeworks

Pipeworks is a mod for Minetest allowing the crafting and usage of pipes and tubes
Other
15 stars 20 forks source link

autocrafter does not invoke on_craft callback, resulting in invalid results #67

Open fluxionary opened 1 year ago

fluxionary commented 1 year ago

e.g. the recipe for crafting a written book + an empty book to create a copy of the empty book results in empty written books. also, crafting moretrees coconut milk (coconut + axe + drinking cup) eats the axe for similar reasons.

see this approach i took for the unified_inventory_plus "craft all" button for an outline of how to do this correctly, though it will need to be adapted to pipeworks (e.g. the autocrafter doesn't have a real "crafting grid" inventory).

S-S-X commented 1 year ago

See also comments on #63 There's some other things that should be considered before/while doing this.