mt-mods / pipeworks

Pipeworks is a mod for Minetest allowing the crafting and usage of pipes and tubes
Other
14 stars 19 forks source link

MineClone containers support #81

Closed nonfreegithub closed 1 year ago

nonfreegithub commented 1 year ago

Compatibility with MineClone containers, the chests are hard to fork, so I do with barrels and maybe with furnaces.

S-S-X commented 1 year ago
Checking mcl-barrels.lua                          1 warning
    mcl-barrels.lua:9:7: unused variable old_barrel_open_def
Checking mcl-furnaces.lua                         6 warnings
    mcl-furnaces.lua:3:7: unused variable old_furnace_active
    mcl-furnaces.lua:19:7: accessing undefined variable mcl_experience
    mcl-furnaces.lua:62:6: line contains trailing whitespace
    mcl-furnaces.lua:73:6: accessing undefined variable awards
    mcl-furnaces.lua:75:6: accessing undefined variable awards
    mcl-furnaces.lua:123:1: line contains only whitespace

seems like luacheckrc and few rather simple things to fix

nonfreegithub commented 1 year ago
mcl-furnaces.lua:19:7: accessing undefined variable mcl_experience
mcl-furnaces.lua:73:6: accessing undefined variable awards
mcl-furnaces.lua:75:6: accessing undefined variable awards

these functions are in external depends mods, dunno how fix

Checking mcl-barrels.lua 1 warning mcl-barrels.lua:9:7: unused variable old_barrel_open_def Checking mcl-furnaces.lua 6 warnings mcl-furnaces.lua:3:7: unused variable old_furnace_active mcl-furnaces.lua:62:6: line contains trailing whitespace mcl-furnaces.lua:123:1: line contains only whitespace

fixed

S-S-X commented 1 year ago

these functions are in external depends mods, dunno how fix

Have to make luacheck aware of that by adding to .luacheckrc configuration file, similar to other mod variables in global scope: https://github.com/mt-mods/pipeworks/blob/ebe23316193e563a264b0f6fec017c02bbc46d4c/.luacheckrc#L20-L23 Just add variable names there.

nonfreegithub commented 1 year ago

done