search

mt-mods / pipeworks

Pipeworks is a mod for Minetest allowing the crafting and usage of pipes and tubes
Other
15 stars 22 forks source link

Teleport tube: replace deprecated inline metadata values ... #93

Closed SmallJoker closed 1 year ago

SmallJoker commented 1 year ago

using a dedicated formspec builder function

This also properly escapes the S translation.

I noticed that this mod is not in minetest-mods, thus here's my patch as a file instead of me pushing it right to the repo:

0001-Teleport-tube-replace-deprecated-inline-metadata-val.patch.txt

BuckarooBanzay commented 1 year ago

I noticed that this mod is not in minetest-mods, thus here's my patch as a file instead of me pushing it right to the repo:

could you elaborate how we would improve the situation?

SmallJoker commented 1 year ago

@BuckarooBanzay Not at all at the moment. It was a self talk to justify dropping the patch file in there instead of forking the project and changing my clone's git config.

S-S-X commented 1 year ago

5.7 docs says that

Usage of the ${k} syntax in formspecs is not deprecated.

Will it be deprecated in next version or something?

SmallJoker commented 1 year ago

@S-S-X Good catch. This is a blunder from my side. I totally missed the second half of the paragraph. Sorry for the fuss - there is no such upcoming (extended) deprecation that I know of.

Here's the original fix about the misplaced escape character. My first commit solves that too, but it did too many unnecessary changes. Feel free to pick whatever you prefer.

0001-Teleport-tube-Move-formspec-escape-outside-of-transl.patch.txt