search

mt-mods / plantlife_modpack

Other
6 stars 11 forks source link

Small naming incosistencies #35

Closed jolesh closed 1 year ago

jolesh commented 1 year ago

At least in the template.txt's are some naming incositencies, maybe the templates are just out dated idk. I know this isn't very important but I just wanted to let you know in case you didn't notice.

Numbering

in trunks: Twigs Roof Corner 1 Twigs Roof Corner 2

in dryplants: Reed Roof Corner Reed Roof Corner 2

in youngtrees: Young Tree (middle) Young Tree 2 (middle)

Capitalisation "loaded" (edit: done)

in poisonivy: [Poison Ivy] Loaded.

in nature_classic: [Nature Classic] loaded!

S-S-X commented 1 year ago

Logging and translations used with logging: Not sure why those "loaded" messages are in translations, they aren't really needed and for most also aren't used.

https://github.com/mt-mods/plantlife_modpack/blob/1894d916094cd0759387bb5c83a22e039ff2179a/trunks/init.lua#L18-L20

These should be removed and probably all of those "loaded" translations too, engine should be able to provide better mod loading info.

https://github.com/mt-mods/plantlife_modpack/blob/1894d916094cd0759387bb5c83a22e039ff2179a/3dmushrooms/init.lua#L72

A bit better but should also be removed because engine is supposed to and already has configuration to log mod loading.

Niklp09 commented 1 year ago

Logging part fixed by https://github.com/mt-mods/plantlife_modpack/pull/46