mt-mods / plantlife_modpack

Other
6 stars 11 forks source link

World shuts down at random #60

Closed Alatarius closed 8 months ago

Alatarius commented 10 months ago

Just as the title says. I will be doing something and then my world will shutdown randomly with this error:

AsyncErr: Lua: Runtime error from mod 'youngtrees' in callback environment_OnGenerated(): ...netest\bin\..\mods\plantlife_modpack\youngtrees\init.lua:137: attempt to concatenate upvalue 'did' (a nil value)
stack traceback:
    ...netest\bin\..\mods\plantlife_modpack\youngtrees\init.lua:137: in function <...netest\bin\..\mods\plantlife_modpack\youngtrees\init.lua:133>
    D:\Games\Minetest\bin\..\builtin\game\register.lua:446: in function <D:\Games\Minetest\bin\..\builtin\game\register.lua:432>
wsor4035 commented 10 months ago

do you have the full modpack enabled, or parts? in theory the function can fail, but it really shouldnt. the reason it randomly shutsdown is because im guessing mapgen is triggered somewhere

edit: are you using regular lua, or luajit?

wsor4035 commented 10 months ago

we could add an assert to make sure that did is initialized, but that wont fix the underlying issue

Alatarius commented 10 months ago

"do you have the full modpack enabled, or parts?" I have whatever was on cdb

"are you using regular lua, or luajit?" I don't understand this question. I just play the regular minetest game if that helps.

Niklp09 commented 10 months ago

The default windows builds use LuaJIT 2.1-beta3 (from 2017)

Alatarius commented 10 months ago

Then I am using LuaJit since I'm running it on Windows 11

⁣Get BlueMail for Android ​

On Sep 26, 2023, 3:59 AM, at 3:59 AM, Niklp @.***> wrote:

The default windows builds use LuaJIT 2.1-beta3 (from 2017)

-- Reply to this email directly or view it on GitHub: https://github.com/mt-mods/plantlife_modpack/issues/60#issuecomment-1735304008 You are receiving this because you authored the thread.

Message ID: @.***>

wsor4035 commented 8 months ago

@Alatarius since i cant reproduce this issue, could you install the worldedit mod, and run the following command //lua minetest.chat_send_all(dump(minetest.registered_decorations["youngtrees:youngtree"])) and report back here what it outputs?

wsor4035 commented 8 months ago

additionally, what other mods do you have enabled in this world?

Alatarius commented 8 months ago

@Alatarius since i cant reproduce this issue, could you install the worldedit mod, and run the following command //lua minetest.chat_send_all(dump(minetest.registered_decorations["youngtrees:youngtree"])) and report back here what it outputs?

It tells me that that is an invalid command, I have all permissions enabled (used /grantme all)

Alatarius commented 8 months ago

additionally, what other mods do you have enabled in this world?

Here is my list: 3d_apple, 3d_armor, ambience, amethyst_new, animalworld, anvil, area_containers, artdeco, auroras, awards, bakedclay, banner, basic_materials, beds, biofuel, biomeinfo, biome_lib, bonemeal, bows, bricks_plus, bucket, bucket_wooden, builtin_item, carpets, castle_farming, castle_gates, castle_lighting, castle_masonry, castle_shields, castle_storage, castle_tapestries, castle_weapons, connected_chests, controls, cottages, cracked_castle, craftguide, darkage, decorations_sea, deepslate, diggicontrol, digilines, digistuff, digtron, display_modpack, doc, doc_basics, doc_encyclopedia, doc_identifier, doc_items, doors, drinks, ebiomes, ethereal, etherium_stuff, everness, factory_bridges, farming, flowerpot, geodes_lib, glass_stained, handle_schematics, hangglider, hopper, illumination, itemframes, item_drop, leads, leather_armor, livingcaves, livingcavesmobs, livingdesert, livingfloatlands, livingjungle, livingnether, loot, lwcomponents, lwscratch, marinara, marinaramobs, mesecons, mesecons_carts, mesecons_x, micupack, minecart, mobkit, mobs, mobs_monster, mobs_skeletons, mobs_sky, mobs_water, mob_horse, modlib, modname_tooltip, modutil, moreblocks, moredecorations, morelights, moreores, moretorches, moretrees, music_modpack, nativevillages, naturalbiomes, nether, new_campfire, obsidianstuff, paintings_gallery, paintings_lib, pipeworks, pipunhole, plantlife_modpack, plaster, powerbanks, redef, regrowing_fruits, rnd, ropes, scaffolding, servercleaner, shallow_ores, signs_lib, simple_furniture, skinsdb, slats, stackslabs, stainedglass, stripped_tree, sugar, swamp, technic_plus, technic_recipes, techpack, tga_encoder, torch_bomb, tpad, ts_furniture, tt, tubelib2, unifieddyes, unified_inventory, variety, visible_sneak, void_chest, we_undo, wilhelminessounds, wine, woodcutting, worldedit, worldedit_hud_helper, xdecor, xmaps, x_enchanting, x_farming

lbaudroit commented 8 months ago

I had a similar problem (world shutting down when I started it), so I tested removing each mod I had in common with Alatarius. It stopped shutting down when I disabled "ebiomes"

wsor4035 commented 8 months ago

we have a winner https://github.com/CowboyLva/ebiomes/blob/09e699d941dd1b058ace6e4819e1782fb510e8cf/rereg.lua#L1154 irresponsibly calling the clear function and not cleaning up the mess they created.

thanks @lbaudroit