Closed Emojigit closed 4 months ago
That's a new warning added in this commit: https://github.com/minetest/minetest/commit/ffec698d3ea707f521fc6ac66a2c786d3851ae60
server log
Those warnings are in the client log
server log
Those warnings are in the client log
Sorry, you're right. I will edit my description now.
Yes. The function fill_line
(or rather probably invalid usage of it, though I think there's an off-by-one error in this function as well) in api.lua
generates [combine
parts which are out of bounds. This is most probably a bug which was just masked by this being a no-op in previous Minetest versions.
(btw, fill_line
is also needlessly inefficient; it could be achieved using a single [resize
+ [multiply
to be escaped and fed into [combine
rather than one sub-modifier per pixel)
@appgurueu - Could you suggest a better routine to accomplish this to avoid the error ?
@appgurueu - Could you suggest a better routine to accomplish this to avoid the error ?
I can imagine some simple monkey-patching (effectively doing the same check Minetest does before handing the texture modifier to Minetest), but I'm not sure how to properly fix this, mainly because I'm not sure what purpose fill_line
serves. It seems it might be related to wrapping lines?
Ook! I fixed the issue on my local fork of signs_lib that we use for Xanadu, just need to download the latest signs_lib from here and do the same.
My own fork: https://codeberg.org/tenplus1/signs_lib
Update: mt-mods signs_lib is working but editing character sheets is taking a while.
The latest signs_lib has been converted to use colorize instead of masking to remove out-of-bounds errors, but for some strange reason github will not allow me to create a pull-request, so here is the latest code with all changes (texture edits and lua)
The
serverclient log is spammed with these: