search

mt-mods / signs_lib

Other
4 stars 12 forks source link

Fix placing certain signs #29

Closed tenplus1 closed 2 months ago

tenplus1 commented 4 months ago

This fixes https://github.com/mt-mods/signs_lib/issues/1 by removing node extensions before placing, just incase player got a hold of certain sign nodes they shouldnt have.

OgelGames commented 4 months ago

Alternatively, you could remove the after_place_node function from the other sign nodes here, after the table gets copied: https://github.com/mt-mods/signs_lib/blob/3d5ba32fa0db60a2741778ed91743411a9bdaa5c/api.lua#L1088

othermounts_def.after_place_node = nil
tenplus1 commented 4 months ago

@OgelGames - Tried that, gives an error, and using an empty function has sign placement issues.

SwissalpS commented 2 months ago

Maybe this change to MT helps in future versions https://github.com/minetest/minetest/commit/408faa11a170ab3ac7352f1ec802b0171349fd0f