search

mt-mods / signs_lib

Other
4 stars 12 forks source link

remove sign entity if sign is gone (due to voxelmanip or such) #9

Closed fluxionary closed 2 years ago

fluxionary commented 2 years ago

fixes #8

parnikkapore commented 2 years ago

This seems to assume that all sign nodes are in the sign group. Which, uhh, basic_signs#1

fluxionary commented 2 years ago

This seems to assume that all sign nodes are in the sign group. Which, uhh, basic_signs#1

Signs get added to the sign group in signs_lib:register_sign. Some other logic in signs_lib already assumes all signs are in that group.

EDIT: Whoops apparently I'm wrong :\

parnikkapore commented 2 years ago

Yea, I also thought that this is the case, but couldn't find such a code.

fluxionary commented 2 years ago

I'll make a new PR for that.