search

mt-mods / technic

Technic mod for Minetest
18 stars 25 forks source link

compatibility with upstream `nodedef.technic_no_network` function stub #206

Closed BuckarooBanzay closed 3 years ago

BuckarooBanzay commented 3 years ago

PR in the "official" technic mod here: https://github.com/minetest-mods/technic/pull/592

Checks if there is a technic_no_network function available on the node definition for a custom infotext

S-S-X commented 3 years ago

I have feeling that approach presented in pull request is not good way to handle infotext as is. If needed it can be easily added here but would be better to take a look at underlying issue and see if there's better ways to fix it and then propose alternative.

S-S-X commented 3 years ago

Commented on upstream PR about how to avoid introducing duplicate callback with different name.

S-S-X commented 3 years ago

Also correct place to implement possible changes is here: https://github.com/mt-mods/technic/blob/aaf4f4768e6258203292164407e3e06fa8da5267/technic/machines/network.lua#L196-L212