search

mt-mods / technic

Technic mod for Minetest
18 stars 25 forks source link

Move infotext set before swap_node and technic_on_disable #207

Closed S-S-X closed 3 years ago

S-S-X commented 3 years ago

callback. (technic_on_disable callback can rewrite it.)

Technic_on-disable callback is now called always when it is defined.

Closes #206 (See issue on minetest-mods/technic for more info)

S-S-X commented 3 years ago

Integration test:

Status: Downloaded newer image for registry.gitlab.com/minetest/minetest/server:latest
Error loading shared library libzstd.so.1: No such file or directory (needed by /usr/local/bin/minetestserver)

Seems like problem with base image? Something changed and now some required libraries missing. Or is it minetest that was updated and now requires more stuff than before? @BuckarooBanzay any ideas or just add apt-get install libzstd to workflow?

github-actions[bot] commented 3 years ago
Click for detailed source code test coverage report ### Test coverage report for Technic CNC 79.43% in 8/8 files: ``` File Hits Missed Coverage ----------------------------------------------------- programs.lua 263 0 100.00% cnc.lua 50 3 94.34% formspec.lua 103 8 92.79% digilines.lua 39 8 82.98% init.lua 19 6 76.00% pipeworks.lua 25 13 65.79% api.lua 157 83 65.42% materials.lua 174 94 64.93% ``` ### Test coverage report for technic 9.62% in 10/102 files: ``` File Hits Missed Coverage -------------------------------------------------------------- machines/HV/generator.lua 9 0 100.00% config.lua 47 4 92.16% machines/register/cables.lua 168 49 77.42% machines/network.lua 193 163 54.21% machines/supply_converter.lua 75 66 53.19% register.lua 20 20 50.00% machines/MV/cables.lua 10 11 47.62% machines/LV/cables.lua 10 11 47.62% machines/HV/cables.lua 9 11 45.00% machines/register/generator.lua 91 114 44.39% util/throttle.lua 0 11 0.00% tools/vacuum.lua 0 32 0.00% tools/tree_tap.lua 0 38 0.00% tools/sonic_screwdriver.lua 0 51 0.00% tools/prospector.lua 0 101 0.00% tools/multimeter.lua 0 208 0.00% tools/mining_lasers.lua 0 65 0.00% tools/mining_drill.lua 0 268 0.00% tools/init.lua 0 14 0.00% tools/flashlight.lua 0 68 0.00% tools/chainsaw.lua 0 115 0.00% tools/cans.lua 0 71 0.00% radiation.lua 0 138 0.00% max_lag.lua 0 12 0.00% machines/switching_station_globalstep.lua 0 58 0.00% machines/switching_station.lua 0 79 0.00% machines/register/solar_array.lua 0 30 0.00% machines/register/recipes.lua 0 78 0.00% machines/register/machine_base.lua 0 166 0.00% machines/register/init.lua 0 22 0.00% machines/register/grindings.lua 0 39 0.00% machines/register/grinder_recipes.lua 0 100 0.00% machines/register/grinder.lua 0 6 0.00% machines/register/freezer_recipes.lua 0 12 0.00% machines/register/freezer.lua 0 6 0.00% machines/register/extractor_recipes.lua 0 71 0.00% machines/register/extractor.lua 0 6 0.00% machines/register/electric_furnace.lua 0 6 0.00% machines/register/compressor_recipes.lua 0 33 0.00% machines/register/compressor.lua 0 6 0.00% machines/register/common.lua 0 114 0.00% machines/register/centrifuge_recipes.lua 0 25 0.00% machines/register/centrifuge.lua 0 6 0.00% machines/register/battery_box.lua 0 238 0.00% machines/register/alloy_recipes.lua 0 40 0.00% machines/register/alloy_furnace.lua 0 30 0.00% machines/power_monitor.lua 0 57 0.00% machines/other/injector.lua 0 85 0.00% machines/other/init.lua 0 8 0.00% machines/other/frames.lua 0 551 0.00% machines/other/constructor.lua 0 103 0.00% machines/other/coal_furnace.lua 0 3 0.00% machines/other/coal_alloy_furnace.lua 0 94 0.00% machines/other/anchor.lua 0 79 0.00% machines/init.lua 0 85 0.00% machines/compat/digtron.lua 0 13 0.00% machines/MV/wind_mill.lua 0 45 0.00% machines/MV/tool_workshop.lua 0 73 0.00% machines/MV/solar_array.lua 0 7 0.00% machines/MV/power_radiator.lua 0 96 0.00% machines/MV/lighting.lua 0 170 0.00% machines/MV/init.lua 0 17 0.00% machines/MV/hydro_turbine.lua 0 44 0.00% machines/MV/grinder.lua 0 6 0.00% machines/MV/generator.lua 0 7 0.00% machines/MV/freezer.lua 0 6 0.00% machines/MV/extractor.lua 0 6 0.00% machines/MV/electric_furnace.lua 0 6 0.00% machines/MV/compressor.lua 0 6 0.00% machines/MV/centrifuge.lua 0 6 0.00% machines/MV/battery_box.lua 0 6 0.00% machines/MV/alloy_furnace.lua 0 6 0.00% machines/LV/water_mill.lua 0 47 0.00% machines/LV/solar_panel.lua 0 27 0.00% machines/LV/solar_array.lua 0 6 0.00% machines/LV/music_player.lua 0 81 0.00% machines/LV/lamp.lua 0 107 0.00% machines/LV/init.lua 0 16 0.00% machines/LV/grinder.lua 0 7 0.00% machines/LV/geothermal.lua 0 56 0.00% machines/LV/generator.lua 0 7 0.00% machines/LV/extractor.lua 0 13 0.00% machines/LV/electric_furnace.lua 0 6 0.00% machines/LV/compressor.lua 0 10 0.00% machines/LV/battery_box.lua 0 6 0.00% machines/LV/alloy_furnace.lua 0 6 0.00% machines/HV/solar_array.lua 0 6 0.00% machines/HV/quarry.lua 0 306 0.00% machines/HV/nuclear_reactor.lua 0 266 0.00% machines/HV/init.lua 0 12 0.00% machines/HV/grinder.lua 0 6 0.00% machines/HV/forcefield.lua 0 213 0.00% machines/HV/electric_furnace.lua 0 6 0.00% machines/HV/compressor.lua 0 6 0.00% machines/HV/battery_box.lua 0 6 0.00% legacy.lua 0 7 0.00% items.lua 0 51 0.00% integration_test.lua 0 24 0.00% init.lua 0 30 0.00% helpers.lua 0 116 0.00% effects.lua 0 3 0.00% crafts.lua 0 86 0.00% ``` ### Raw test runner output for geeks: CNC: ``` ●●●●●●●●●●●●●●●●●●●●●● 22 successes / 0 failures / 0 errors / 0 pending : 0.161714 seconds ``` Technic: ``` ●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●◌●●●●● 57 successes / 0 failures / 0 errors / 1 pending : 0.134658 seconds Pending → spec/supply_converter_spec.lua @ 99 Supply converter building overloads network spec/supply_converter_spec.lua:99: overload does not work with supply converter ```
BuckarooBanzay commented 3 years ago

nice :+1:

S-S-X commented 3 years ago

Btw, this can potentially have side effects but if that happens I'd recommend trying to fix machines that are causing problems. Basically what changed is that technic_on_disable is always called when it is defined while before this PR technic_on_disable was only called when it was defined AND machine did not specify technic_disabled_machine_name.

If some machine implemented technic_on_disable but stopped using it (and code was forgotted) then it might fail, also if same definition is used for both active and inactive machine but only active provided technic_disabled_machine_name then about same situation.