S-S-X
commented
3 years ago Nice addition to engine, however we want to stop and think a bit before using that.
Some time ago max lag thing had 2 problems:
- Max lag values provided by engine were very bad for this use case.
- Max lag was parsed from server status message because there was no engine API.
https://github.com/mt-mods/technic/pull/193 fixed actual max lag values that are actually usable for technic. It did also get around status message parsing but not by using engine API.
Now this PR will use engine API which is very nice but it would also return back to very bad max lag calculation done by engine, values returned by that thing are useless for reducing lag caused by technic.
See PR comments for custom method to get max lag: https://github.com/mt-mods/technic/pull/193 (tldr: engine max lag will stuck at high values for way too long when insignificant but long lag spikes happen, not metric we're interested of)
wsor4035
https://github.com/minetest/minetest/commit/4fca601e0cf74ce642e4e49ca7d4fe3e59915846