Closed S-S-X closed 3 years ago
Maybe rename 1.2.1 to 1.2.x or 1.x if this will be merged. That would then be 1.x release branch.
Wanted to test a bit so I pulled stuff from extended-tests #208 here. Also other improvements added for tests like reporting and other mineunit updates.
The config changes should not be included in 1.2.x
, only bug-fixes should be added. (tests are fine too, those are independent from the code)
Reverted commit that included unnecessary configuration stuff.
Now it might be better anyway to forget about 1.2.x and bump version to 1.3.0 After all this simply adding compatibility for Minetest 5.5 and not exactly bug fix.
Had to create a new branch to add the other fixes, this branch bugged out for me because of the /
in its name :/
Proposed 1.2.2
release and 1.2.x
branch here: https://github.com/mt-mods/technic/tree/1.2.xx (rename after 1.2.x/max_lag-fix
is deleted)
Had to create a new branch to add the other fixes, this branch bugged out for me because of the
/
in its name :/Proposed
1.2.2
release and1.2.x
branch here: https://github.com/mt-mods/technic/tree/1.2.xx (rename after1.2.x/max_lag-fix
is deleted)
That's weird because / in branch name is actually common practice for release and bugfix branches. I guess can add those here too.
Did you try origin/1.2.x/max_lag-fix?
Mineunit updates should be included because old thing has bug that always overwrites coverage badge, no matter where you push changes...
Ah, I mixed myself up there... It was the 1.2.1
branch that bugged (detached head when pulled it locally), and 1.2.x/max_lag-fix
prevented me from creating a 1.2.x
branch.
Mineunit updates should be included because old thing has bug that always overwrites coverage badge, no matter where you push changes...
Hmm... which commit is that?
Ah, I mixed myself up there... It was the
1.2.1
branch that bugged (detached head when pulled it locally), and1.2.x/max_lag-fix
prevented me from creating a1.2.x
branch.
1.2.1 branch was deleted and restored but is branch we should work on because there's other earlier fixes skipping other breaking changes. Were you still able to start 1.2.xx from 1.2.1 with related history?
Mineunit updates should be included because old thing has bug that always overwrites coverage badge, no matter where you push changes...
Hmm... which commit is that?
Commits that change minetest.conf and mineunit.yaml, not 100% sure if that's all needed as I just picked complete previous commits here without actually doing anything.
Were you still able to start 1.2.xx from 1.2.1 with related history?
Now that I fixed it, yes :D I think I added the mineunit-fixing commits there too.
Actually I renamed it, use the right words GitHub...
Fix #218 for 1.2.2 release, compatibility for Minetest 5.5.