mt-mods / technic

Technic mod for Minetest
18 stars 25 forks source link

1.2.x/max lag fix #219

Closed S-S-X closed 3 years ago

S-S-X commented 3 years ago

Fix #218 for 1.2.2 release, compatibility for Minetest 5.5.

S-S-X commented 3 years ago

Maybe rename 1.2.1 to 1.2.x or 1.x if this will be merged. That would then be 1.x release branch.

S-S-X commented 3 years ago

Wanted to test a bit so I pulled stuff from extended-tests #208 here. Also other improvements added for tests like reporting and other mineunit updates.

OgelGames commented 3 years ago

The config changes should not be included in 1.2.x, only bug-fixes should be added. (tests are fine too, those are independent from the code)

S-S-X commented 3 years ago

Reverted commit that included unnecessary configuration stuff.

Now it might be better anyway to forget about 1.2.x and bump version to 1.3.0 After all this simply adding compatibility for Minetest 5.5 and not exactly bug fix.

OgelGames commented 3 years ago

Had to create a new branch to add the other fixes, this branch bugged out for me because of the / in its name :/

Proposed 1.2.2 release and 1.2.x branch here: https://github.com/mt-mods/technic/tree/1.2.xx (rename after 1.2.x/max_lag-fix is deleted)

S-S-X commented 3 years ago

Had to create a new branch to add the other fixes, this branch bugged out for me because of the / in its name :/

Proposed 1.2.2 release and 1.2.x branch here: https://github.com/mt-mods/technic/tree/1.2.xx (rename after 1.2.x/max_lag-fix is deleted)

That's weird because / in branch name is actually common practice for release and bugfix branches. I guess can add those here too.

Did you try origin/1.2.x/max_lag-fix?

Mineunit updates should be included because old thing has bug that always overwrites coverage badge, no matter where you push changes...

OgelGames commented 3 years ago

Ah, I mixed myself up there... It was the 1.2.1 branch that bugged (detached head when pulled it locally), and 1.2.x/max_lag-fix prevented me from creating a 1.2.x branch.

Mineunit updates should be included because old thing has bug that always overwrites coverage badge, no matter where you push changes...

Hmm... which commit is that?

github-actions[bot] commented 3 years ago
Click for detailed source code test coverage report ### Test coverage report for technic 54.91% in 100/107 files: ``` File Hits Missed Coverage -------------------------------------------------------------- max_lag.lua 12 0 100.00% machines/register/init.lua 22 0 100.00% machines/register/grinder.lua 6 0 100.00% machines/register/freezer_recipes.lua 13 0 100.00% machines/register/freezer.lua 6 0 100.00% machines/register/extractor.lua 6 0 100.00% machines/register/electric_furnace.lua 6 0 100.00% machines/register/compressor.lua 6 0 100.00% machines/register/centrifuge.lua 6 0 100.00% machines/MV/solar_array.lua 9 0 100.00% machines/MV/grinder.lua 8 0 100.00% machines/MV/generator.lua 9 0 100.00% machines/MV/freezer.lua 8 0 100.00% machines/MV/extractor.lua 8 0 100.00% machines/MV/electric_furnace.lua 8 0 100.00% machines/MV/compressor.lua 8 0 100.00% machines/MV/centrifuge.lua 14 0 100.00% machines/MV/battery_box.lua 17 0 100.00% machines/MV/alloy_furnace.lua 8 0 100.00% machines/LV/solar_array.lua 8 0 100.00% machines/LV/init.lua 16 0 100.00% machines/LV/grinder.lua 9 0 100.00% machines/LV/generator.lua 9 0 100.00% machines/LV/extractor.lua 9 0 100.00% machines/LV/electric_furnace.lua 8 0 100.00% machines/LV/compressor.lua 13 0 100.00% machines/LV/battery_box.lua 15 0 100.00% machines/LV/alloy_furnace.lua 8 0 100.00% machines/HV/solar_array.lua 8 0 100.00% machines/HV/init.lua 12 0 100.00% machines/HV/grinder.lua 8 0 100.00% machines/HV/generator.lua 9 0 100.00% machines/HV/electric_furnace.lua 8 0 100.00% machines/HV/compressor.lua 8 0 100.00% machines/HV/battery_box.lua 17 0 100.00% legacy.lua 33 0 100.00% items.lua 125 0 100.00% ../technic_worldgen/config.lua 9 0 100.00% ../technic_worldgen/crafts.lua 128 1 99.22% config.lua 42 1 97.67% machines/register/compressor_recipes.lua 36 1 97.30% machines/LV/geothermal.lua 75 3 96.15% machines/LV/solar_panel.lua 42 2 95.45% machines/register/solar_array.lua 40 2 95.24% ../technic_worldgen/nodes.lua 133 7 95.00% machines/MV/init.lua 16 1 94.12% crafts.lua 117 10 92.13% machines/LV/lamp.lua 170 15 91.89% machines/LV/water_mill.lua 67 6 91.78% machines/network.lua 300 31 90.63% machines/register/alloy_recipes.lua 27 3 90.00% machines/register/grindings.lua 42 5 89.36% init.lua 29 4 87.88% machines/other/init.lua 7 1 87.50% machines/register/grinder_recipes.lua 104 16 86.67% ../technic_worldgen/rubber.lua 64 10 86.49% machines/register/recipes.lua 56 10 84.85% ../technic_worldgen/oregen.lua 155 28 84.70% machines/register/cables.lua 178 40 81.65% tools/init.lua 12 3 80.00% machines/register/machine_base.lua 164 41 80.00% ../technic_worldgen/init.lua 12 3 80.00% machines/register/battery_box.lua 219 71 75.52% machines/register/centrifuge_recipes.lua 21 7 75.00% machines/switching_station.lua 77 27 74.04% effects.lua 5 2 71.43% radiation.lua 242 103 70.14% machines/other/coal_furnace.lua 2 1 66.67% machines/switching_station_globalstep.lua 40 21 65.57% machines/register/generator.lua 122 88 58.10% machines/MV/hydro_turbine.lua 40 29 57.97% machines/MV/tool_workshop.lua 49 41 54.44% machines/supply_converter.lua 76 67 53.15% register.lua 21 19 52.50% tools/cans.lua 53 48 52.48% tools/vacuum.lua 19 21 47.50% tools/tree_tap.lua 24 27 47.06% machines/power_monitor.lua 37 42 46.84% machines/other/coal_alloy_furnace.lua 56 70 44.44% machines/init.lua 42 53 44.21% machines/other/injector.lua 45 62 42.06% machines/HV/quarry.lua 119 168 41.46% machines/other/constructor.lua 50 84 37.31% machines/HV/nuclear_reactor.lua 117 208 36.00% machines/MV/cables.lua 10 19 34.48% machines/LV/cables.lua 10 19 34.48% machines/register/alloy_furnace.lua 10 20 33.33% tools/chainsaw.lua 40 83 32.52% machines/HV/cables.lua 9 19 32.14% machines/register/common.lua 40 85 32.00% tools/sonic_screwdriver.lua 18 40 31.03% helpers.lua 36 80 31.03% machines/HV/forcefield.lua 78 180 30.23% tools/mining_drill.lua 76 226 25.17% machines/LV/music_player.lua 22 70 23.91% machines/other/anchor.lua 14 74 15.91% machines/compat/digtron.lua 2 11 15.38% tools/prospector.lua 16 92 14.81% machines/register/extractor_recipes.lua 6 57 9.52% util/throttle.lua 1 10 9.09% tools/mining_lasers.lua 0 65 0.00% tools/flashlight.lua 0 68 0.00% machines/other/frames.lua 0 551 0.00% machines/MV/wind_mill.lua 0 45 0.00% machines/MV/power_radiator.lua 0 96 0.00% machines/MV/lighting.lua 0 170 0.00% integration_test.lua 0 24 0.00% ``` ### Raw test runner output for geeks: ``` ●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●◌●●●●● 63 successes / 0 failures / 0 errors / 1 pending : 13.68627 seconds Pending → spec/supply_converter_spec.lua @ 99 Supply converter building overloads network spec/supply_converter_spec.lua:99: overload does not work with supply converter ```
S-S-X commented 3 years ago

Ah, I mixed myself up there... It was the 1.2.1 branch that bugged (detached head when pulled it locally), and 1.2.x/max_lag-fix prevented me from creating a 1.2.x branch.

1.2.1 branch was deleted and restored but is branch we should work on because there's other earlier fixes skipping other breaking changes. Were you still able to start 1.2.xx from 1.2.1 with related history?

Mineunit updates should be included because old thing has bug that always overwrites coverage badge, no matter where you push changes...

Hmm... which commit is that?

Commits that change minetest.conf and mineunit.yaml, not 100% sure if that's all needed as I just picked complete previous commits here without actually doing anything.

OgelGames commented 3 years ago

Were you still able to start 1.2.xx from 1.2.1 with related history?

Now that I fixed it, yes :D I think I added the mineunit-fixing commits there too.

OgelGames commented 3 years ago

Actually I renamed it, use the right words GitHub...