Sonic screwdriver causes issues with wallmounted, colorwallmounted, etc.

[wsor4035]

see issue https://github.com/mt-mods/homedecor_modpack/issues/33

as @OgelGames calls it, a feature bug, the mtg screwdriver mod has advanced a lot since https://github.com/mt-mods/technic/blob/bc9a7759f3d902d2c72cd2763fe08e0e9fce4340/technic/tools/sonic_screwdriver.lua#L7 for instance wallmounted and colorwallmounted support have been added https://github.com/minetest/minetest_game/blob/master/mods/screwdriver/init.lua#L68-L83 as well as the on_rotate field. additionally https://github.com/mt-mods/technic/blob/bc9a7759f3d902d2c72cd2763fe08e0e9fce4340/technic/tools/sonic_screwdriver.lua#L66 should check minetest.is_creative_enabled which is per player rather than global

• [ ] respect on_rotate
• [ ] update to support (color)wallmounted nodes
• [ ] #268

[OgelGames]

Not calling on_rotate is intentional, for the same reason it doesn't call can_dig: https://github.com/mt-mods/technic/blob/b26132a98b1edf1ac5957d4649b9a6b49787d106/technic/tools/sonic_screwdriver.lua#L41

Also the creative check will be fixed by #233

[wsor4035]

Not calling on_rotate is intentional, for the same reason it doesn't call can_dig:

https://github.com/mt-mods/technic/blob/b26132a98b1edf1ac5957d4649b9a6b49787d106/technic/tools/sonic_screwdriver.lua#L41

Also the creative check will be fixed by #233

seems easier to add a group to those nodes to bypass, rather than breaking other mods with a on_rotate, specifically ones that disallow

[S-S-X]

Just yesterday I was thinking about these bugs that have become important features for some players, someone mentioned dropping light nodes somewhere and Technic dropping led light nodes feature came into my mind.

It is terrible bug for some players and useful feature for others so I thought of adding configuration:

drop_light_nodes = true|false

Situation is very similar with this issue (just bit worse results if I've understood issue correctly) so would it be possible to introduce configuration option here? Any estimates how much extra work and maintenance issues that would generate?

[wsor4035]

sounds like death by configuration. the more options you add for specific things, the more code and variety of options combined you will have to test to make sure nothing breaks

[S-S-X]

That's very true but as opinions are very divided it needs decision to either have less options/code while only making some people happy or have more options/code while making more people happy. First option of course means less maintenance work and second one means more maintenance work.

Why I had this question there:

Any estimates how much extra work and maintenance issues that would generate?

Reason for that question is to determine what it would take to support both sides and if it is really possible at all. I think it is worth some discussion because during at least past 3 years this issue has popped up multiple times with multiple mods and many wanted to keep behavior adding workarounds to other mods.

(just that "death by configuration" simply means going too far where consequences outweigh benefits, determine if that's the case here)

I do also think it would be better for maintenance and development to change other mods in a way that they would allow doing things that are near impossible without sonic screwdriver but that might actually be a lot more initial work and way harder to get through.