mt-mods / technic

Technic mod for Minetest
18 stars 25 forks source link

technic:motor to basic_materials:motor #333

Closed nonfreegithub closed 1 year ago

nonfreegithub commented 1 year ago

technic:motor does not exist, technic requires basic_materials, which adds the alias technic:motor to basic_materials:motor

basic_materials:motor is used in other crafts

wsor4035 commented 1 year ago

citation: https://github.com/mt-mods/basic_materials/blob/e4a122dfdd991f5a3af27c9a84418fddf22fad49/aliases.lua#L13

brings this inline with the rest of crafts citation: https://github.com/search?q=repo%3Amt-mods%2Ftechnic%20basic_materials%3Amotor&type=code

S-S-X commented 1 year ago

Any other mods known that also registers it?

edit. found this for one: minetest.register_alias("technic:motor", "homedecor:motor") Could be good to check around a bit and see if this breaks some stuff and see if anything could be done easily. Current alias offers some freedom for bit wider use cases but still doesn't exactly look that good.

wsor4035 commented 1 year ago

Any other mods known that also registers it?

edit. found this for one: minetest.register_alias("technic:motor", "homedecor:motor") Could be good to check around a bit and see if this breaks some stuff and see if anything could be done easily. Current alias offers some freedom for bit wider use cases but still doesn't exactly look that good.

doesnt really matter, all the rest of this mod are in the proper itemname form. see my edited comment. additionally your homedecor:motor is moot as well https://github.com/mt-mods/basic_materials/blob/e4a122dfdd991f5a3af27c9a84418fddf22fad49/aliases.lua#L12C1-L12C1

wsor4035 commented 1 year ago

https://content.minetest.net/zipgrep/065bc1c5-7fc0-40ce-ac9f-e7e68c73e750/ technic:motor, nothing worth caring about https://content.minetest.net/zipgrep/12a2ed1f-3857-48b8-8240-a6ec75dddc54/ homedecor:motor, nothing worth caring about