Closed OgelGames closed 10 months ago
Hmm, something seems to have broken mineunit 👀
Failure → spec/lv_network_spec.lua @ 122
LV machine network smelts ores
Failure → spec/lv_network_spec.lua @ 132
LV machine network grinds ores
Failure → spec/lv_network_spec.lua @ 142
LV machine network comperess sand
I tested these in-game and they work as normal.
Basically Mineunit isn't approving this:
table.insert(minetest.registered_on_mods_loaded, 1, cache_all_recipes)
This was one of those things where I wanted to add clear errors and requirement for explicit configuration to allow questionable things. Currently results are still mixed: some stuff has clear assert
s, some is fully protected, some logs warnings and some is permissive.
Fixtures can be used and in other projects have been used to patch similar things but personally I'd recommend against it.
In this case, instead of silently adding required features through fixtures, I'd vote for some public shaming and pointing the finger at Mineunit until fixed.
Tested this again, everything seems to be working correctly, so I think this is safe to merge.
Rewrite of recipe code to fix some issues and add new features. (sorry this took so long)
cooking
recipes) are now cached for performance.Fixes #201, and the issues discussed in #328 and #335.
@nonfreegithub @ThePython10110