mt-mods / technic

Technic mod for Minetest
18 stars 25 forks source link

Remove leftovers from frames, add README.md for Mineunit spec dirs #355

Closed imre84 closed 7 months ago

imre84 commented 8 months ago

as far as I'm able to tell enable_frames doesn't do anything, I removed that, and also updated technic/spec/fixtures/technic.conf to reflect the defaults as per technic/config.lua

low impact PR

S-S-X commented 8 months ago

Wouldn't start limiting tests to only default stuff, if there's special need to actually run tests for default configuration it can be done as a separate configuration test utilizing multiple configuration files one for each scenario (like default, all enabled, all disabled, etc.).

For information, currently things that are actually tested in one way or another:

imre84 commented 8 months ago

bf7a18b isn't supposed to be part of this PR

imre84 commented 8 months ago

Hello, I understand neither messages sent by S-S-X

imre84 commented 7 months ago

please disregard this PR, how do I delete it?

S-S-X commented 7 months ago

please disregard this PR, how do I delete it?

Can be just closed or if you like you could also just revert technic/spec/fixtures/technic.conf to version in master branch and then we merge that simple README.md change, it isn't big change but it is still good as it would remove unneeded legacy stuff.

I mean just git checkout origin/master technic/spec/fixtures/technic.conf and commit as usual, will be squashed together anyway when merging.

S-S-X commented 7 months ago

Noticed that enable_frames was also on technic.conf for Mineunit so removed it from there too. Searched a bit if there's anything else about frames and didn't found anything, should be clean now.