mt-mods / technic

Technic mod for Minetest
18 stars 25 forks source link

Quarry missing digiline commands for setting toggles #366

Open SwissalpS opened 5 months ago

SwissalpS commented 5 months ago

The toggles for

can't be toggled using digilines.

Is this deliberate or is it only because nobody bothered to add them?

Now that quarries are more efficient, players are starting to build massive amounts of them. Toggling each quarry manually to not restart when moved can be quite a task.

SwissalpS commented 5 months ago

The state of those toggles is also not in the get report, which I don't think is nesessary even if they could be toggled via digiline.

OgelGames commented 5 months ago

It was intentional to not have those toggles controllable by digilines, and my reasoning is because in most cases they only need to be toggled once, so digiline commands would be redundant most of the time.

Also, if all the quarries are connected to digilines, then mesecon control isn't needed, and the restart command can be used.

IMO, instead of adding digiline commands, support for the quarry should be added to metatool's container tool: https://github.com/S-S-X/metatool/tree/master/containertool

SwissalpS commented 5 months ago

Even if you only need to set the toggle once, when doing it on several dozen quarries it does get tiresome.

Meta-tool is a fine alternative by me.

S-S-X commented 5 months ago

For container tool I think it'd be good addition no matter how this issue gets closed.

As there's already toggles available on formspec I think it can well fit within metatool's intended scope (which for unprivileged tools is basically to only allow doing things that could be and are intended to otherwise achievable in game without additional privileges). For tool itself it should also be fairly simple addition as most of these are anyway handled by simulating player sent form fields.