mt-mods / technic

Technic mod for Minetest
18 stars 25 forks source link

Use moreores tin when moreores and mcl_core are detected #383

Closed programmerjake closed 2 months ago

programmerjake commented 2 months ago

Fixes: #381

OgelGames commented 2 months ago

We really should switch to using xcompat, but I see no reason not to add this small change in the meantime :+1:

OgelGames commented 2 months ago

Actually now that I look a bit closer, you should add the changes to lines 17 and 18, like this:

    tin_ingot = has_moreores and "moreores:tin_ingot" or has_mcl and "mcl_core:iron_ingot" or "default:tin_ingot",
    tin_lump = has_moreores and "moreores:tin_lump" or has_mcl and "mcl_raw_ores:raw_iron" or "default:tin_lump",
programmerjake commented 2 months ago

Actually now that I look a bit closer, you should add the changes to lines 17 and 18, like this:

  tin_ingot = has_moreores and "moreores:tin_ingot" or has_mcl and "mcl_core:iron_ingot" or "default:tin_ingot",
  tin_lump = has_moreores and "moreores:tin_lump" or has_mcl and "mcl_raw_ores:raw_iron" or "default:tin_lump",

no, because you need default:tin_* even if you have moreores. so I thought that would make the boolean expression too complex, so I used a much easier to understand if

programmerjake commented 2 months ago
  without moreores with moreores
minetest game default's tin default's tin
mineclone* mineclone's iron moreores's tin
OgelGames commented 2 months ago

Oh, right... because moreores doesn't register its tin when default tin is available 🤦