search

mt1006 / mc-nbtac-mod

Minecraft mod adding suggestions for NBT tags in commands
https://modrinth.com/mod/nbt-autocomplete
GNU Lesser General Public License v3.0
23 stars 1 forks source link

[Feature] Wiki Page for commands #20

Closed SpyCoder77 closed 1 month ago

SpyCoder77 commented 1 month ago

You should make a button next to the autocomplete that has the wiki page for it.

mt1006 commented 1 month ago

I don't think it's even possible, as NBT tags don't have their separate pages. On each entity page there's just list of available tags with short descriptions.

Edit: I'm talking about minecraft.wiki ofc

mt1006 commented 1 month ago

I could theoretically add short descriptions for each tag, but:

  1. tags for entities and block entities are mostly dynamically generated and not predefined, thanks to that they don't require too much updating
  2. it would be too much work, even if I would copy everything from minecraft.wiki
SpyCoder77 commented 1 month ago

You could just add a button that takes you too the link. Also, I don't fully understand number 1.

mt1006 commented 1 month ago

That would have to be a link to the entire entity page, so you would have to find tag in it anyway.

As for point 1, suggestions for items are predefined in resource files, but suggestions for entities and block entities aren't. In short, when first running mod it disassembles Minecraft code in search of NBT related method calls and that way it knows the tag names and types. To give some additional suggestions, like automatic entity id suggestions there are also predefined predictions in resource files which are responsible for fixing some missing tags and these additional suggestions (subtypes).

SpyCoder77 commented 1 month ago

Ok, I understand.

mt1006 commented 1 month ago

As I said earlier, I may some day add it, but that won't be soon. I also see a need for some form of tag descriptions, but I also don't see an easy way I could add them.

SpyCoder77 commented 1 month ago

You could just have a very long json. That would be very hard and tedious to make though.

On Sun, Mar 31, 2024 at 6:13 PM Damian @.***> wrote:

As I said earlier, I may some day add it, but that won't be soon. I also see a need for some form of tag descriptions, but I also don't see an easy way I could add them.

— Reply to this email directly, view it on GitHub https://github.com/mt1006/mc-nbtac-mod/issues/20#issuecomment-2028929908, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7BDZQZLDTOPQP5AE3AXWT3Y3CDBTAVCNFSM6AAAAABFQSYBQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYHEZDSOJQHA . You are receiving this because you modified the open/close state.Message ID: @.***>