search

mtakaki / cachet-url-monitor

URL monitor plugin for cachethq.io
MIT License
125 stars 49 forks source link

Return status as integer #63

Closed mazhead closed 5 years ago

mazhead commented 5 years ago

During the first start the if statement on line 237 does not get evaluated correctly and will not "return" Therefore by any restart the first evaluation triggers a update even if the original status is same.

mazhead commented 5 years ago

@mtakaki, I think the test was not able to upload the tests, maybe a re-run would be useful but I do not have permissions for that.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling d0f7140cf26f6f8d101037044b70a1d3139f8ac7 on mazhead:master into 3af53ce9b618feefc0ff2a6cd0f67856021de4f7 on mtakaki:master.

mtakaki commented 5 years ago

Great finding, @mazhead! Thank you for fixing it!