search

mtakaki / cachet-url-monitor

URL monitor plugin for cachethq.io
MIT License
125 stars 49 forks source link

Dont update if same #64

Closed mazhead closed 5 years ago

mazhead commented 5 years ago

By a case where allowed_fails > 0 and one failure is received the url monitor pushes a unnecessary update as the component state was not changed, resulting in a notification of "component is operational", but in fact the component was still operation before the update.

This creates another api call (get) towards the cachet, but it is a better trade-off to prevent unnecessary notifications for end-users.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling c893354f8cc085f6f796000d36a814cc67015830 on mazhead:dont_update_if_same into 3af53ce9b618feefc0ff2a6cd0f67856021de4f7 on mtakaki:master.

mtakaki commented 5 years ago

Another great bug fix! Thank you so much, @mazhead