search

mtakaki / cachet-url-monitor

URL monitor plugin for cachethq.io
MIT License
125 stars 49 forks source link

feat(multihreading): each url has it's own thread #71

Closed aberenshtein closed 4 years ago

aberenshtein commented 5 years ago

HI, we have more than 20 components on cachet and we didn't want to have a cachet-url-monitor service for each one so this PR opens a thread for each URL. It's backward compatible so you can still monitor a single URL but I changed the config file to be compatible to multiple URLS.

Would love to get your thoughts on this pr and indeed you would like to merge it I would fix the tests

aberenshtein commented 5 years ago

@mtakaki

mtakaki commented 4 years ago

That's a really good solution, @aberenshtein! Do you think you could fix the broken unit tests? If so, I can merge it in.

mtakaki commented 4 years ago

If you grant me permission to edit the branch, I can try fixing the tests.

dylie commented 4 years ago

Does this work with the main build already? @mtakaki

Leen15 commented 4 years ago

Hi, Any ETA here?

mtakaki commented 4 years ago

I guess I'll have to manually bring this branch over to this repo in order to fix the build. I'll give it a try...

mtakaki commented 4 years ago

I've moved this over to #76