mtakaki / cachet-url-monitor

URL monitor plugin for cachethq.io
MIT License
124 stars 48 forks source link

Avoid using schedule #91

Closed nijel closed 4 years ago

nijel commented 4 years ago

Execute task directly as there is already code taking care of the delays.

Fixes #90

Maybe I missed something, but I see no reason of using additional scheduler, when the delays are already handled inside the code.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.2%) to 75.598% when pulling 8bf8a8480ce9f058d7a06d4eec13c22f8cf07594 on nijel:schedule into ae0555cb705a6e5ed16d292ca8aaf638df2a0332 on mtakaki:master.

mtakaki commented 4 years ago

Codacy Here is an overview of what got changed by this pull request:


Coverage decreased per file
===========================
- cachet_url_monitor/scheduler.py  -2

See the complete overview on Codacy

nijel commented 4 years ago

@mtakaki Yes, some lines were removed, so the number of covered lines is lower as well.

mtakaki commented 4 years ago

Thanks for submitting this, @nijel! Have you manually tested your change to ensure it still runs in the correct frequency? This isn't easy to test through unit test.

nijel commented 4 years ago

It runs fine for me. It's powering https://cachet.weblate.org/

mtakaki commented 4 years ago

Sounds good to me!