search

mtakaki / cachet-url-monitor

URL monitor plugin for cachethq.io
MIT License
124 stars 48 forks source link

Use per thread scheduler #92

Closed nijel closed 4 years ago

nijel commented 4 years ago

This avoids running tasks in more threads.

Fixes #90

This is alternative to #91 in case the schedule module is really useful or planned for something in the future. It will need some tests polishing as well, but I think #91 is better approach.

mtakaki commented 4 years ago

I actually like this solution better, but I'm not sure if #91 won't prevent it from running continuously. I'll pull your branch to check if it still runs as expected.

Once again, thank you so much for so many fixes!

nijel commented 4 years ago

Both approaches work fine for me. I don't see reason to use two ways to schedule checks - sleep in dedicated thread and scheduler.