Avoid pushing metrics twice

mtakaki / cachet-url-monitor

URL monitor plugin for cachethq.io

MIT License

124 stars 48 forks source link

Avoid pushing metrics twice #93

Closed nijel closed 4 years ago

nijel commented 4 years ago

The metrics were pushed unconditionally in the execute method and conditionally in decorators. I think only decorators should submit it.

coveralls commented 4 years ago

Coverage decreased (-0.06%) to 75.772% when pulling 5e891782f77d21b41ddf89a2b8802ade72d18586 on nijel:metrics into ae0555cb705a6e5ed16d292ca8aaf638df2a0332 on mtakaki:master.

mtakaki commented 4 years ago

Good catch! I completely missed this. Thank you so much for fixing it.