search

mtanda / grafana-heatmap-epoch-panel

Apache License 2.0
33 stars 3 forks source link

Browser hangs on low window size #18

Closed flxai closed 7 years ago

flxai commented 7 years ago

Hello again,

I'd like to use the plugin to use a low window size. Unfortunately, the browser hangs after reloading the dashboard containing the plugin.

Steps to reproduce

  1. Create a new dashboard
  2. Add a HeatmapEpoch panel
  3. Add a random metric available to you
  4. Change value of Heatmap Options > Window Size to some value below 18
  5. Save the dashboard
  6. Reload the dashboard
  7. Browser should now hang

Is this a known bug? Are you able to reproduce this?

I tested this with the newest Firefox and Chromium.

mtanda commented 7 years ago

Sorry for late response. I can't reproduce, I'll check if I get enough time.

flxai commented 7 years ago

Sorry to bug, but did you find some time yet?

mtanda commented 7 years ago

Today, I try it again. And success to replicate. But, I don't have time to investigate the issue now. To fix crash bug, it takes too much time. Sorry, please wait.

mtanda commented 7 years ago

I can't replicate this on Chrome, it might be caused by Browser difference.

mtanda commented 7 years ago

hmm, ticks.time becomes 0. It should not be 0. image

mtanda commented 7 years ago

https://github.com/mtanda/grafana-heatmap-epoch-panel/pull/21 This PR might fix your issue. Please check.

flxai commented 7 years ago

It works. Thanks!