search

mtanda / grafana-sumologic-datasource

Apache License 2.0
10 stars 4 forks source link

Feat: stream support #13

Open mtanda opened 6 years ago

mtanda commented 6 years ago

Stream support might be useful in some case, consider to support it.

Use case:

Related code: https://github.com/grafana/grafana/blob/livefeed/public/app/plugins/datasource/livefeed/module.ts#L13 https://github.com/grafana/grafana/blob/v5.1.3/public/app/features/panel/metrics_panel_ctrl.ts#L264-L289

kumoroku commented 6 years ago

are you thinking live tail?

or are you thinking something more like the live mode that's available for dashboards in the Sumo UI?

mtanda commented 6 years ago

I'm intended to support query result loading while status is GATHERING RESULTS. https://help.sumologic.com/APIs/Search-Job-API/About-the-Search-Job-API

Currently, wait for DONE GATHERING RESULTS, and then start loading.

Grafana can handle Observable object, so datasource can return result until finish loading.

mtanda commented 6 years ago

Live tail support is really useful, Grafana already has the ability to support it. If Live tail is provide as public API, I want to try it :-)

kumoroku commented 6 years ago

DONE GATHERING RESULTS

ah, ok, got it and makes sense. it will make the dashboard feel much faster because something is being displayed while the query is still finishing in the backend. very nice.

Live tail

unfortunately the live tail API is not public. we are in the process of making public APIs for many things in the platform, so hopefully we will get to that one as well.