mtangoo / wxDatabase

wxWidgets library for connecting to major relational database
http://mtangoo.github.io/database/index.html
37 stars 17 forks source link

[CI]: Add workflows/ubuntu.yml and macos #29

Open Jarod42 opened 3 weeks ago

Jarod42 commented 3 weeks ago
mtangoo commented 3 weeks ago

Hi Jarod, Thanks for interest in contributing. it is welcome!

Jarod42 commented 3 weeks ago

Hi Jarod, Thanks for interest in contributing. it is welcome!

Mostly to upgrade dependencies of Codelite which uses embed old WxDatabaseLayer that I want to change to submodule. Happy there is someone to handle incoming PRs :-)

can you share why ODBC build failed? May be I can help make it build?

From failing build

[ 46%] Building CXX object CMakeFiles/wxdatabase.dir/src/database/mysql/mysql_resultset_metadata.cpp.o
In file included from /home/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_resultset_metadata.cpp:5:
/usr/include/mariadb/mysql_com.h:3:2: warning: #warning This file should not be included by clients, include only <mysql.h> [-Wcpp]
    3 | #warning This file should not be included by clients, include only <mysql.h>
      |  ^~~~~~~

warning to fix

[ 56%] Building CXX object CMakeFiles/wxdatabase.dir/src/database/odbc/odbc_preparedstatement.cpp.o
/home/runner/work/wxDatabase/wxDatabase/src/database/odbc/odbc_param.cpp: In member function ‘SQLLEN* wxOdbcParameter::GetParameterLengthPtr()’:
/home/runner/work/wxDatabase/wxDatabase/src/database/odbc/odbc_param.cpp:255:10: error: invalid conversion from ‘long long int*’ to ‘SQLLEN*’ {aka ‘long int*’} [-fpermissive]
  255 |   return &m_nBufferLength;
      |          ^~~~~~~~~~~~~~~~
      |          |
      |          long long int*

Type mismatch

It seems easy to fix, but not familiar enough to fix it in portable way across all odbc types.

Primary goal of this PR is to add CI. Other ones would come normally :)

There is FreeTDS, Please have a look at it

It seems it is not installable via apt-get and requires self build :-/ It might be added after IMO.

mtangoo commented 3 weeks ago

Great then. Can you open new issue with details for the build failure? Include version of Mysql/mariadb version that you have installed

I wi review and merge this one. But would be glad to fix the other issue too

Jarod42 commented 3 weeks ago

https://github.com/mtangoo/wxDatabase/issues/30 and https://github.com/mtangoo/wxDatabase/issues/31 created