search

mtangoo / wxDatabase

wxWidgets library for connecting to major relational database
http://mtangoo.github.io/database/index.html
37 stars 17 forks source link

Build warnings with mySQL #31

Open Jarod42 opened 1 week ago

Jarod42 commented 1 week ago

From CI: https://github.com/Jarod42/wxDatabase/actions/runs/11632894931/job/32396938912

/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:134:37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:134:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:134:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:148:37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:148:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:148:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:1[90](https://github.com/Jarod42/wxDatabase/actions/runs/11632894931/job/32396938912#step:6:91):37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:190:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:190:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:202:37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:202:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:202:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:217:37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:217:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:217:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:260:37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:260:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:260:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
In file included from /Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_resultset_metadata.cpp:5:
/opt/homebrew/include/mysql/mysql_com.h:3:2: warning: This file should not be included by clients, include only <mysql.h> [-W#warnings]
#warning This file should not be included by clients, include only <mysql.h>
 ^
1 warning generated.
6 warnings generated.
Jarod42 commented 1 week ago

Fixed by https://github.com/Jarod42/wxDatabase/tree/warnings Waiting previous PR about CI before to submit this one.