search

mtarld / api-platform-ms-bundle

A set of tools to use Api Platform in a microservice context
MIT License
66 stars 8 forks source link

[Log] Add log for each request #52

Closed ismail1432 closed 3 years ago

ismail1432 commented 3 years ago

Should fix #47 wait #49 before merging

mtarld commented 3 years ago

https://github.com/mtarld/api-platform-ms-bundle/pull/49 is merged :tada: You can now rebase your branch

ismail1432 commented 3 years ago

I Rebased and add tests :fire: cc @mtarld

ismail1432 commented 3 years ago

One more thing, I'm wondering if the logging behavior should be configurable (ie: enabled/disabled accordingly to a configuration).

You have a good idea as usual :+1: Config should be global or per MS or both?

mtarld commented 3 years ago

Config should be global or per MS or both?

The config should be global. For instance: "I'm a microservice and I will call the X microservice". Therefore I can see a problem with the current log sentence. Because $microservice is in fact representing the targeted microservice IMHO, the sentence should be instead Calling "{microservice_name}" microservice: "{method} {url}".

ismail1432 commented 3 years ago

Hey @mtarld I'm very sorry for the delay, I'll finish it very soon :rocket:

mtarld commented 3 years ago

Thank you @ismail1432!