search

mtarld / apip-ddd

An example of hexagonal API Platform 3 implementation
MIT License
322 stars 55 forks source link

Collection operations not ACID complient #46

Closed sebastianstucke87 closed 11 months ago

sebastianstucke87 commented 1 year ago

Hi! First off, thank you for this demo repo! This really did help me get my head around ApiPlattform in a non-vanilla "Symfony architecture" 😀👍

Second, I noticed in POST api/books/anonymize, that each SQL update statement is executed in its own transactions, instead of the entire update being done in a single transaction:

https://github.com/mtarld/apip-ddd/blob/main/src/BookStore/Application/Command/AnonymizeBooksCommandHandler.php#L26

yceruto commented 11 months ago

Fixed in https://github.com/mtarld/apip-ddd/pull/52

sebastianstucke87 commented 11 months ago

Fixed in #52

Awesome, thank you! 😃🎉