mtatsuma / MMM-WeatherChart

Magic Mirror Module for displaying weather chart
MIT License
26 stars 8 forks source link

memory leak or something #47

Closed luxiouronimo closed 1 year ago

luxiouronimo commented 1 year ago

i luv this module but after about a day my 1GB ram rpi3 will be out of memory and things will grind to a halt as (i assume) it struggles with swap/paged/virtual memory/or whatever..

i've just confirmed that without this module memory usage is more or less consistent (this setup has had a 250+ day uptime before updating to the latest MM), but since adding this module, as i've been monitoring it, the system becomes unusable after about a day.

mtatsuma commented 1 year ago

Thank you for telling me the issue. I will investigate about that.

mtatsuma commented 1 year ago

@luxiouronimo I fixed the issue. Please clone the latest version of MMM-WeatherChart module (v3.5.0) and try it.

Thank you!

luxiouronimo commented 1 year ago

that seems to have fixed it; at nearly 24hrs runtime i'm within 10mb memory usage of when i last pm2 restart mm'd; thank u thank u for the quick turnaround…

on a separate note, i use this with

    "dataNum": 48,
    "timeOffsetHours": -24,
    "dataType": "hourly",

can we get a (configurably colored) vertical line indicating the current time?

also hiding the zeros in the precipitation (rain/snow/?) at the bottom would be nice…

also i should point out if the time offset isn't a multiple of 24 then the nighttime dotted line is messed up..

plz & thank u

mtatsuma commented 1 year ago

@luxiouronimo

hiding the zeros in the precipitation (rain/snow/?) at the bottom would be nice…

You can set "showZeroRain": false and "showZeroSnow": false to hide the zeros.

For example:

image

if the time offset isn't a multiple of 24 then the nighttime dotted line is messed up..

I cannot reproduce the issue. It's helpful to show your full configuration and the captured display.

luxiouronimo commented 1 year ago

oo perfect, sorry i shoulda reviewed the readme and seen the showZero options…

does the timeOffsetHours work with negative numbers? so i can see the previous day as well as the next day?

mtatsuma commented 1 year ago

@luxiouronimo timeOffsetHours with negative number works, but you may be misunderstanding the config.

The displayed data is current and forecast weather (not the past weather). timeOffsetHours is used to shift and change the displayed hour numbers. The far left side of data always shows the current weather.