mtconnect / ros_bridge

ROS Python Adapter and Ruby Robot Simulator
http://www.ros.org/wiki/mtconnect
8 stars 5 forks source link

Two very similar cnc_simulator ruby files. #10

Closed shaun-edwards closed 11 years ago

shaun-edwards commented 11 years ago

There are two nearly identical cnc_simulator ruby files in the ros_bridge/simulator directory. One of them appears to use port 5001 as opposed to port 5000. Which one is correct. Can we get rid of one? If we do, we will have to update the ros_bridge/mtconnect/mtconnect_ros_bridge/scripts/mtconnect_setup.sh script.

wsobel commented 11 years ago

The 5001 version was created by SWrI, with the dual agent configuration. We should make it a command line argument.

Sent from my iPhone

On Feb 21, 2013, at 21:13, Shaun Edwards notifications@github.com wrote:

There are two nearly identical cnc_simulator ruby files in the ros_bridge/simulator directory. One of them appears to use port 5001 as opposed to port 5000. Which one is correct. Can we get rid of one? If we do, we will have to update the ros_bridge/mtconnect/mtconnect_ros_bridge/scripts/mtconnect_setup.sh script.

— Reply to this email directly or view it on GitHub.

wsobel commented 11 years ago

Changed the cnc_simulator to take an argument and added the argument to the startup script and removed duplicate cnc_simulator_5001.