search

mtconnect / ros_bridge

ROS Python Adapter and Ruby Robot Simulator
http://www.ros.org/wiki/mtconnect
8 stars 5 forks source link

String mismatch in mtconnect_ros_bridge package configuration files #7

Closed jrgnicho closed 11 years ago

jrgnicho commented 11 years ago

Description: The bridge_publisher.py node complains about a mismatch when parsing the 'NOT_READY' element in the input configuration file bridge_publisher_config.py. The configuration file contains the string 'NOT READY' without the underscore character. The same string 'NOT READY' was found in the bridge_subscriber_config.yaml file

Observed Behavior: The following error code was produced by the bridge_publisher.py node: CONVERSION ERROR IN TOPIC CONFIG FILE: XML is 'NOT_READY' --> CONFIG is ['ACTIVE', 'READY', 'NOT READY', 'UNAVAILABLE', 'COMPLETE']

Temporary Solution Applied: The white space was replaced by a underscore character in every instance found in both files bridge_publisher_config.yaml and bridge_subscriber_config.yaml. After that change was made the error code above was no longer produced. If this fix impacts other components then it should be reverted and the proper fix should be applied instead, otherwise this issue can be closed.

swiedmann commented 11 years ago

This correction is acceptable. The configuration file tag must match the XML tag.