search

mtcp-stack / mtcp

mTCP: A Highly Scalable User-level TCP Stack for Multicore Systems
Other
1.98k stars 436 forks source link

Fixed mtcp doesn't notify onvm to reclaim resource when a mtcp based … #220

Closed lyuxiaosu closed 5 years ago

lyuxiaosu commented 5 years ago

…process exits

lyuxiaosu commented 5 years ago

A mtcp based application should call onvm's interface to notify onvm when it exits

lyuxiaosu commented 5 years ago

@koolzz please review

koolzz commented 5 years ago

@lyuxiaosu Good catch, this should fix bad cleanup. The only thing I'm not sure if it needs the extra dpdk logic. I think it waits for other cores above your fix? We should probably just call nflib stop and return, I'll take a look later.

ajamshed commented 5 years ago

Please re-submit the PR to the devel branch. I will immediately merge the request.

lyuxiaosu commented 5 years ago

@ajamshed OK, I am doing that

ajamshed commented 5 years ago

By the way, I just found out mTCP devel branch's compilation is breaking with the recent addition of CCP module. I am currently fixing it. Will let you know once it is stable soon.

lyuxiaosu commented 5 years ago

@ajamshed OK, I will re-submit after you fix it

ajamshed commented 5 years ago

@lyuxiaosu ,

Please go ahead and resubmit the patch to the devel branch.

lyuxiaosu commented 5 years ago

@ajamshed I updated the code and did the same modification based on the latest code, then submitted another pull request to devel branch. I am not familiar about this, please let me know if I did the wrong operations, or if I just need to submit the old branch to the devel without needing to generate another branch.

ajamshed commented 5 years ago

All good! I have merged your PR in the devel branch. Thanks. Sorry for the delay.