Closed danielsantiago closed 7 years ago
Thanks @danielsantiago !
Looks like there are two failed tests according to Travis. Just take a look at those, and if needed provide some new tests for the coverage.
For DayOfMonth with L
, I see where that is used by itself to signify the last day of the month, but for W
can you provide documentation from an existing real cron instance (like cronie, or pixie cron) where W
isn't used in conjunction with a numerical value?
There was a lot of stuff the old 1.x branch let through, so I'm trying to stick much closer to real cron implementations.
@dragonmantank I made the changes to pass the test, also include new tests.
Right now we can't use 'L' or 'W' for the DayOfMonthField. We get the following error:
Fatal error: Uncaught InvalidArgumentException: Invalid CRON field value L at position 2 in vendor/mtdowling/cron-expression/src/Cron/CronExpression.php on line 154
This pull request solve this problem