search

mtdowling / cron-expression

CRON for PHP: Calculate the next or previous run date and determine if a CRON expression is due
http://mtdowling.com/blog/2012/06/03/cron-expressions-in-php/
MIT License
4.9k stars 335 forks source link

Mark this as abandoned on packagist #169

Closed SamMousa closed 4 years ago

SamMousa commented 5 years ago

Since this repo no longer sees any development (since it has continued in a different repo), it makes sense to mark the accompanying package as abandoned on packagist.

GrahamCampbell commented 4 years ago

Bump.

dragonmantank commented 4 years ago

Marked it as abandoned in composer.json as of v1.2.2. There's been enough time for both Laraval and others to switch over.

I cannot mark it directly in Packagist as abandoned hough, as this is a personal repo and I don't have access.

tfettig commented 4 years ago

Just for a PSA, I opened up #176 since the new 1.2.2 tag caught up some extra code from master that caused issues with Laravel 5.4. I'm not expecting anything to be done here since all this stuff is old, but hopefully this will help someone who's stuck.

dragonmantank commented 4 years ago

Thanks! Will leave this issue open for a bit in case others stop by looking.

On Fri, Dec 27, 2019, 6:02 PM Travis Fettig notifications@github.com wrote:

Just for a PSA, I opened up #176 https://github.com/mtdowling/cron-expression/issues/176 since the new 1.2.2 tag caught up some extra code from master that caused issues with Laravel 5.4. I'm not expecting anything to be done here since all this stuff is old, but hopefully this will help someone who's stuck.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mtdowling/cron-expression/issues/169?email_source=notifications&email_token=AAA2TFAY2Z3WPHLFDVYAQD3Q22CRNA5CNFSM4HOCSSE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHX4CUQ#issuecomment-569360722, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2TFA5SNBPZUY5BYPHQD3Q22CRNANCNFSM4HOCSSEQ .

GrahamCampbell commented 4 years ago

Looks like tagging 1.2.2 was a bug, and contains breaking changes. Maybe the tag should be deleted?

GrahamCampbell commented 4 years ago

Marked it as abandoned in composer.json as of v1.2.2.

That doesn't do anything I'm afraid. No machine will look at that. It must be done from the packagist UI.

dragonmantank commented 4 years ago

Deleted v1.2.2 and re-pushed as v1.2.3, I had forgotten that the master branch on here did have some of what ended up being v2. The bug should have gone away.

That being said, as I've mentioned before since this is a personal repo I cannot mark it abandoned in Packagist. I've requested that it be done so, but it haven't seen mtdowling do it yet. The best I can do is document it in the meantime.

GrahamCampbell commented 4 years ago

I don't understand why we need any new release after 1.2.1. Adding the abandoned flag into the composer.json doesn't do anything, since no machine ever looks at it. It doesn't have the affect of making it abandoned?

dragonmantank commented 4 years ago

It makes it as clear as can be done at this time that it is abandoned. I'm well aware that Composer itself won't care, but at least it's documented in the composer.json file now.

Again, as I've said multiple times, I would love to have this properly marked as abandoned, but it is impossible for me to do so.