closes #205

[codecov-io]

Current coverage is 85.78% (diff: 88.40%)

Merging #230 into develop will increase coverage by 0.05%

@@            develop       #230   diff @@
==========================================
  Files            42         42          
  Lines          1801       1808     +7   
  Methods           0          0          
  Messages          0          0          
  Branches        388        392     +4   
==========================================
+ Hits           1544       1551     +7   
  Misses          169        169          
  Partials         88         88          

Powered by Codecov. Last update db993c3...d5f6ee6

[daivanov]

Can this patch be significantly smaller than 20000 lines?

[daivanov]

I merged 39 lines from your commits in commit 7604a0dda59f21b2623e3432726ca396a45b567a into the develop branch. Now you need to rebase.

[maxdidato]

Most of the lines are test fixtures. The production code is actually very small. I have also added another annotation @IgnoreNonPodamAnnotations which will get rid of any non Podam annotations, this is an easy fix when some annotations clash

[daivanov]

I'm sorry, but I cannot merge patch changing 2061 lines mostly because of white spaces as is.

[maxdidato]

No problem, I'll tidy it up On Fri, 13 Jan 2017 at 21:59, Daniil Ivanov notifications@github.com wrote:

I'm sorry, but I cannot merge patch changing 2061 lines mostly because of white spaces as is.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/devopsfolks/podam/pull/230#issuecomment-272559354, or mute the thread https://github.com/notifications/unsubscribe-auth/ACwgWZgXYFTnQuY1HFlBqCqcmkg9P0mmks5rR_OygaJpZM4Lh5Sk .

[daivanov]

Could you please split commit 1d7606e4d2a8699bed36b7e9d2ce834a2423cc3a into part with test and without?

[daivanov]

Partially merged.

[daivanov]

If you want, you can give me your real name and/or email for inclusion into pom.xml's contributors section.

[maxdidato]

Massimiliano Di Dato didatomax@gmail.com

So you basically cherry picked the changes, no more tidying up required?

[daivanov]

Yes, cherry-picked and then amended. Large patches are hard to review and they pollute a sources history.

[maxdidato]

Hi @daivanov . Thanks for including me in the contributor lists on the pom.xml in master. Could you please also amend my details with the one I posted previously on this thread?

And maybe adding me to the contributors list. Thanks

[daivanov]

I beg a pardon. I somehow missed your email. Now added.

[maxdidato]

Thanks On Mon, 22 May 2017 at 17:44, Daniil Ivanov notifications@github.com wrote:

I beg a pardon. I somehow missed your email. Now added.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/devopsfolks/podam/pull/230#issuecomment-303155293, or mute the thread https://github.com/notifications/unsubscribe-auth/ACwgWeLre-rMM00mOaJL8tKkXOryYPfsks5r8btZgaJpZM4Lh5Sk .