mtedone / podam

PODAM - POjo DAta Mocker

https://mtedone.github.io/podam

MIT License

326 stars 749 forks source link

Warning problems corrections + format corrections #254

Closed dedece35 closed 7 years ago

dedece35 commented 7 years ago

My first commit before give you help on your project. We use Podam on all our projects in my job in PagesJaunes (french famous website).

I specilly am interested to work on @Pattern annotation : we use it a lot.

codecov-io commented 7 years ago

Codecov Report

Merging #254 into develop will not change coverage. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #254   +/-   ##
==========================================
  Coverage      90.38%   90.38%           
  Complexity       576      576           
==========================================
  Files             42       42           
  Lines           1727     1727           
  Branches         345      345           
==========================================
  Hits            1561     1561           
  Misses           105      105           
  Partials          61       61

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37feb12...fb5a6fc. Read the comment docs.

dedece35 commented 7 years ago

Sorry but I don't understand errors ...

with JDK 1.6 : all test are OK ("mvn clean verify")
with JDK 1.8 : all test are OK (Travis) => command launched OK : "mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V"
with JDK 1.7 : errors with Travis ?! => command launched KO : "mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V" mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V The JAVA_HOME environment variable is not defined correctly This environment variable is needed to run this program NB: JAVA_HOME should point to a JDK not a JRE

With 1.7 environment, it seems to have a pb with JAVA_HOME variable, no ?

daivanov commented 7 years ago

Thank you for you patch. oraclejdk7 doesn't seem to be supported by Travis any more and they suggest to switch to openjdk7 instead.

$ jdk_switcher use oraclejdk7
Switching to Oracle JDK7 (java-7-oracle), JAVA_HOME will be set to /usr/lib/jvm/java-7-oracle
update-java-alternatives: directory does not exist: /usr/lib/jvm/java-7-oracle

dedece35 commented 7 years ago

OK. thanks for your explain. Do you think you could accept my PullRequest ?

daivanov commented 7 years ago

Yes, but could you incorporate the fix in .travis.yml and could you please make a pull request against develop branch. Also I don't think double empty lines separating methods is a formatting problem. Rather this is a good thing helping to avoid conflicts sometimes.

dedece35 commented 7 years ago

OK. I will correct these things. Sorry, it's my automatic formatter deleted "double empty lines". I will disable my automatic formatter for this project :)

dedece35 commented 7 years ago

Can you refused this PR ? I will submit new PR.