ledinscak commented 6 years ago

Don't know if you missed it on purpose, but method name suggests it should be there :-)

codecov-io commented 6 years ago

Codecov Report

Merging #258 into develop will decrease coverage by 0.1%. The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop     #258      +/-   ##
=============================================
- Coverage      90.38%   90.28%   -0.11%     
  Complexity       576      576              
=============================================
  Files             42       42              
  Lines           1727     1729       +2     
  Branches         345      346       +1     
=============================================
  Hits            1561     1561              
- Misses           105      107       +2     
  Partials          61       61

Impacted Files	Coverage Δ	Complexity Δ
...rc/main/java/uk/co/jemos/podam/api/PodamUtils.java	`84.28% <0%> (-2.48%)`	`27 <0> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba82978...1ba65e4. Read the comment docs.

daivanov commented 6 years ago

Hi,

Could you please explain your patch?

Thanks, Daniil

ledinscak commented 6 years ago

Hello, I just saw method signature that takes primitive type, and noticed that boolean (primitive type) does not exist and does not do Boxing to Boolean.class. Sorry but I did not check where method is beeing invoked in rest of app. Maybe I am missing something there, I just wanted to get your attention that maybe boolean was forgotten there. Keep up the god work with this nice library!

daivanov commented 6 years ago

I originally confused this pull request with spam. Sorry about that. Now it is merged, thank you.

ledinscak commented 6 years ago

No problem ;-)

mtedone / podam

Added conversion of boolean primitive type to Boolean #258

Codecov Report