search

mtekk / Breadcrumb-NavXT

The longest maintained Breadcrumb plugin for WordPress
https://mtekk.us/code/breadcrumb-navxt
52 stars 25 forks source link

Fix BuddyPress theme_compat Induced Undefined Indicies #94

Closed mtekk closed 8 years ago

mtekk commented 10 years ago

Looks like BuddyPress introduces a few faux post types for the sake of Theme Compatibility. Naturally, these never make it into the $wp_post_types global, which causes issues when on these BuddyPress pages. A few possible solutions:

  1. Introduce a new option loader/template loader that automatically feeds in good defaults if nothing is found. This would solve the issue for all edge cases. However, it really only masks the issue, and presents the issue that you can have a more visible disconnect between the settings page and actual behavior (bad).
  2. Introduce a BuddyPress compatibility extension plugin. Will be more work, but should be able to handle this. However, this won't help those who don't use the extenion plugin (still produces PHP warnings for them (bad)).
mtekk commented 9 years ago

It appears there may be a simmilar issue with bbPress

mtekk commented 9 years ago

Since we're handling the bbPress issues in 5.2.0, let's move it to 5.3.0 (would like to talk with jjj as well to see if there is anything BuddyPress is planning on doing on this front)

mtekk commented 9 years ago

See: https://wordpress.org/support/topic/buddypress-and-breadcrumbs https://wordpress.org/support/topic/notice-issues

mtekk commented 9 years ago

It looks like what was causing the PHP errors has gone away in newer BuddyPress versions. However, a BuddyPress extension plugin will be needed for full support.

mtekk commented 9 years ago

After digging into this more, it appears the cause of the PHP errors is fixed in newer BuddyPress versions and the remaining items are the domain of an extension plugin.

mtekk commented 8 years ago

Initial plugin created, see https://github.com/mtekk/Breadcrumb-NavXT-BuddyPress-Extensions