mtempleheald / journeyasdata

MIT License
0 stars 0 forks source link

DependsUpon does not fire on Dropdown change #55

Open rod-laycock opened 3 years ago

rod-laycock commented 3 years ago

You can write a DependsUpon condition under a Dropdown - but it doesn't fire until you change a Yes/No

mtempleheald commented 3 years ago

This is because each question can have a single action, onBlur in this case. I'm hoping it can stay this way but the resolution of this issue will decide that outcome. onBlur is recommended over onChange for select elements.

I've noticed that this feels a little clunky for API calls too - see address dropdown after entering postcode, especially on mobile.

mtempleheald commented 2 years ago

My current thinking is that anytime there is a background action which the user is waiting for e.g. Address lookup before moving on to following questions, there needs to be an action button to make it explicit. I think onBlur is fine for fast/local actions, including dependsUpon, but we need visual feedback for actions.