URI encode path params - Githubissues

mtennoe / swagger-typescript-codegen

A Swagger Codegenerator tailored for typescript.

Apache License 2.0

140 stars 52 forks source link

URI encode path params #94

Closed Shahab96 closed 4 years ago

Shahab96 commented 4 years ago

Update test snapshot to reflect uri encoded path params
Update method template to uri encode path params supplied by consumers
Run npm audit fix to fix some security vulnerabilities
Bumped version to 2.0.2

This commit fixes issue: #92

Shahab96 commented 4 years ago

I'm unsure as to whether this should be a patch or a minor version bump, as now that path parameters will be uri encoded, any consumers who are manually encoding their path parameters will be broken by this change.

mtennoe commented 4 years ago

Re. backwards compatibility - That is a very good question. For backwards compatiblity breaking changes we want to bump the major version, but this is more of a small bugfix, so a major version bump seems drastic. I am leaning towards a major bump to "do it right" though. @Markionium - Thoughts?

mtennoe commented 4 years ago

@Shahab96 - This looks good! Before I merge, let's be safe and bump it to 3.0.0. If you want to you can check it in as the existing version (2.0.1), and I can bump it to 3 when I publish it

Shahab96 commented 4 years ago

@Shahab96 - This looks good! Before I merge, let's be safe and bump it to 3.0.0. If you want to you can check it in as the existing version (2.0.1), and I can bump it to 3 when I publish it

I can just bump the version to 3.0.0. No problem :)

mtennoe commented 4 years ago

@Shahab96 - Merged and published as 3.0.0. I also did a quick npm audit fix to bump the vulnerable packages, published as 3.0.1