search

mterwill / office-hours-help-queue

A queue to help manage office hours for large courses
GNU General Public License v3.0
84 stars 21 forks source link

Update request.js.jsx to redact google hangouts links #157

Closed csseecss closed 4 years ago

csseecss commented 4 years ago

Hi @mterwill ! Thank you for maintaining the website. In 281 (and I believe in other classes) there's an ongoing issue of google hangout links being visible in the description box (allows unwanted parties access the link and close the hangouts link for instructors). This pull request is a bit of a hackish way to go around it, as it's not implemented in server and the check might be a false positive for a general google link (includes a comment regarding that)

Would you want this to be implemented server-side? I think this solution can work out temporarily and I'm not familiar with Ruby yet.

PS: This is only to address the recent adoption of online office hours due to the recent context.

mterwill commented 4 years ago

👋 thanks for the contribution! I think implementing this server-side would be good, and perhaps a more general solution, like #69 / #145. I'm fooling around with a branch over here, but it's not quite ready yet. Will keep thinking about this over the weekend.

mterwill commented 4 years ago

@csseecss, is it alright with you if we close this in favor of #161?

mterwill commented 4 years ago

Closing. If the new private mode doesn't suit your needs, please feel free to open an issue. Thanks!