Course queues loading for 20+ minutes for some students

mterwill / office-hours-help-queue

A queue to help manage office hours for large courses

GNU General Public License v3.0

84 stars 21 forks source link

Course queues loading for 20+ minutes for some students #174

Closed tabaddor closed 4 years ago

tabaddor commented 4 years ago

It seems as if for some students, myself included, when clicking on the queue for a specific course (for example, EECS 388), I am met with a loading screen for 20-30+ minutes. Below is a screenshot:

Capture

Interestingly, not every course results in this error. For some (EECS 270, for example), I can sign up for the queue immediately as expected.

KhidirA commented 4 years ago

same for eecs 281

oalejel commented 4 years ago

please resolve this soon!

mterwill commented 4 years ago

Could you please post a screenshot of your browser console?

oalejel commented 4 years ago

Could you please post a screenshot of your browser console?

I'm a teaching assistant, so I can only try to display the loading behavior being described by students with OH for classes that I'm not enrolled for. Here's EECS 482's queue, with unending loading indicators:

michaeljecmen commented 4 years ago

I poked around for quite some time, here's what I've found:

queue can be loaded when there's no one in it, but when there is one or more student in the queue it it loads endlessly like in the picture
happens consistently for other courses too (ones I'm not registered for this semester, ones I'm taking currently, and eecs 281 for which I am an IA)
could have to do with me being a late hire (some uniqname issue? not sure if those are even checked in oh queues)
suspicious X-XSS-Protection: 1; mode=block tag in dev console for element associated with other student in queue when I try to inspect element (I'll try to recreate this asap)
does not work even with a fresh install of chrome, chromium, or firefox and minimal security settings, doubt it's a browser issue

mterwill commented 4 years ago

I can't reproduce locally but the "undefined is not an object" on this.props.location.trim() is a relatively recent addition, in https://github.com/mterwill/office-hours-help-queue/pull/173/files. Will revert that for now.

mterwill commented 4 years ago

Revert is deployed.

mterwill commented 4 years ago

Ah - looks like this only happens in private mode, where we don't include a location for other students' requests:

https://github.com/mterwill/office-hours-help-queue/blob/36734df33c1dee84be9cdcf68f49168a3a364db3/app/helpers/course_queues_helper.rb#L30

michaeljecmen commented 4 years ago

Reverted version works! Thanks.