search

mterwill / office-hours-help-queue

A queue to help manage office hours for large courses
GNU General Public License v3.0
84 stars 21 forks source link

Attach message to ping #184

Closed mbwangfpdc closed 3 years ago

mbwangfpdc commented 3 years ago

Currently, the only means of communicating with a student in the queue is to ping them, which is vague, broadcast, which bothers everyone unnecessarily, or to email them, which can be cumbersome. I would like to be able to attach a message when I ping a student.

Right now, I'd primarily use this to remind individual remote students to add online meeting passwords in their help request descriptions. I imagine this feature might also be helpful during in-person office hours, in order to remind students about adding their physical location.

mterwill commented 3 years ago

Hey @mbwangfpdc, I like this idea! Would happily accept a PR if you or others are interested.

annieli555 commented 3 years ago

Hi! My name is Annie Li and I am currently a student in EECS 481 (Software Engineering). For this class, my partner, Phoebe Liang (@pl98 ), and I are working on an assignment that involves contributing to an open-source project. We are very interested in working on some open issues for the EECS OH queue and would love to get started on this and perhaps some others, if they are still needed.

mterwill commented 3 years ago

Hi @annieli555 and @pl98, sounds great! Let me know if you have any questions as you're getting started.

pl98 commented 3 years ago

@mterwill Thanks! We ran into this output from running the setup script: Not delivering sessions due to an invalid api_key. How should we go about fixing this?

mterwill commented 3 years ago

That should be fine to ignore. The message is from Bugsnag, an error reporting tool we use in production.

pl98 commented 3 years ago

Hi @mterwill, we're starting to work on this issue this week and ran into some questions. Our first idea was to implement some kind of overlay form using a Modal window from Semantic UI, but we're having some issues with integration. Is there a way to import and use components from libraries like Semantic UI in the current project setup?

mterwill commented 3 years ago

👋 we're using an old version of semantic-ui, 2.2.4 (vendored here), and not the React bindings, as those didn't exist when the app was written. You should be able to use any semantic-ui components from that version, though you'd have to manage the modal lifecycle yourself, which could get tricky with React. It's not as pretty, but you could maybe use window.prompt instead? 🤷‍♂️

pl98 commented 3 years ago

Thanks! I was able to get the modal component working so far, just need to update the ping message correctly before sending the notification.