search

mterwill / office-hours-help-queue

A queue to help manage office hours for large courses
GNU General Public License v3.0
84 stars 21 forks source link

Increase max length on student request location field #186

Closed ghost closed 3 years ago

ghost commented 3 years ago

Closes #185.

mterwill commented 3 years ago

👋 thanks @akiekintveld for the contribution!

Currently, this will overflow with long locations.

image

What do you think about truncating the long text with some CSS? We could do something like this in LabeledItem:

          <div style={{ maxWidth: '50ch', textOverflow: 'ellipsis', overflow: 'hidden' }}>
          {this.props.children}
          </div>

A double click/copy/paste (or a click on the link if starts with https) preserves the entire field.

ghost commented 3 years ago

Oh, weird, when I tested it out (in Safari 14, Chrome 85, and Firefox 81), it was wrapping the text, which looked fine. I also like how the ellipses look though, seems to work well (had to add whiteSpace: 'nowrap' as well otherwise it kept wrapping).

ghost commented 3 years ago

I see there's a check expected before this can be merged, do I need to do something to get that to run?

mterwill commented 3 years ago

Fixed in #187

mterwill commented 3 years ago

Deployed!