search

mterwill / office-hours-help-queue

A queue to help manage office hours for large courses
GNU General Public License v3.0
86 stars 21 forks source link

Ping opens too many message windows #191

Closed mbwangfpdc closed 3 years ago

mbwangfpdc commented 3 years ago

When I click the "ping" button, it opens a dialogue to add a message to my ping (good work, BTW @annieli555 , this is going to be really useful!). However, there's a bug which causes "ping" to open a dialogue window for each student in the queue. For example, if there are 4 students in the queue and I press "ping", it opens 4 dialogue windows (I have to x out 4 windows to get back to the normal queue screen). I don't know which student sees the result of which ping dialogue.

bkayes commented 3 years ago

I'm noticing the same issue, except that it opened 2 dialogs for each person in the queue (4 people in the queue, had to exit out of 8 dialogs)

mterwill commented 3 years ago

I'll revert for now. @annieli555 / @pl98, do you have time to look into this? Thanks!

pl98 commented 3 years ago

@mterwill We can take a look at this issue this week.