search

mtesseract / nakadi-client

Haskell Client Library for the Nakadi Event Broker
Other
13 stars 9 forks source link

Added typeclasses for business and datachange events #104

Closed vitold closed 6 years ago

vitold commented 6 years ago

@mtesseract Hi, that's my suggestion for the event models. WIP

Closes #58

mtesseract commented 6 years ago

Hi, thanks for the PR.

I'm not sure I understand this, though.

In my opinion, we should have less law-less typeclasses instead of more. It is not obvious to me why having support for Business Events requires an implementation that seems so different than the rest of the event handling code.

This PR introduces four more typeclasses — that's a lot. And why do we need seperate publishing functions (publishBusinessEvents) for these events?

Some kind of rationale for this is missing for me. On the other hand, I haven't looked at Business Events for quite some time. So, I will change this if time permits.

Thanks!

mtesseract commented 6 years ago

I propose the following PR instead: https://github.com/mtesseract/nakadi-client/pull/106/files

mtesseract commented 6 years ago

Hi, thanks again but I have closed this in favour of #106.