search

mtesseract / nakadi-client

Haskell Client Library for the Nakadi Event Broker
Other
13 stars 9 forks source link

Implement BusinessEvents #106

Closed mtesseract closed 6 years ago

mtesseract commented 6 years ago

Implement BusinessEvents with custom JSON deserialization/serialization implementations. Including tests.

mtesseract commented 6 years ago

@etorreborre @erthalion Care to review this? This should finally bring support for Business Events to nakadi-client. There is another PR open for this (https://github.com/mtesseract/nakadi-client/pull/104), but I don't consider this be a consistent addition to nakadi-client.

erthalion commented 6 years ago

@mtesseract Sure, will jump on it this evening

etorreborre commented 6 years ago

I have nothing to add on top of what @erthalion reviewed so far. So if all comments are addressed :+1:

mtesseract commented 6 years ago

Cool, thank you all for the incredibly quick review! As I think all issues are addressed I will proceed with merging.